Issue 1236613003: [Merge to M44] [SafeBrowsing] Send pingbacks for additional file types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236613003: [Merge to M44] [SafeBrowsing] Send pingbacks for additional file types. (Closed)

Created:
5 years, 5 months ago by asanka

Modified:
5 years, 5 months ago

Reviewers:

CC:
chromium-reviews, extensions-reviews_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Merge to M44] [SafeBrowsing] Send pingbacks for additional file types. [SafeBrowsing] Send pingbacks for additional file types. This change expands the list of file types supported by Safe Browsing. Downloads of these files will now behave in a manner similar to .exe file downloads. I.e. there will be no dangerous file warning at the start of the download. Instead, the download will run to completion and the user will be prompted based on the results of the Safe Browsing query. BUG=507821 Review URL: https://codereview.chromium.org/1230483005 Cr-Commit-Position: refs/heads/master@{#337986} (cherry picked from commit d55999aedb284074bb86700c3e04d2abd5a5023b) [Downloads] Consider Windows PowerShell file types as dangerous. BUG=507795 Review URL: https://codereview.chromium.org/1220333007 Cr-Commit-Position: refs/heads/master@{#337839} (cherry picked from commit b17687c98e6999780ead655d4a93932d01db3832) Committed: https://chromium.googlesource.com/chromium/src/+/31fcfe13a5c92618171e40b599920c58f9a2be56

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+270 lines, -122 lines)			Patch
M	chrome/browser/download/download_extensions.cc	View	7 chunks	+90 lines, -35 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View	2 chunks	+73 lines, -61 lines	0 comments	Download
M	chrome/common/safe_browsing/download_protection_util.cc	View	1 chunk	+55 lines, -24 lines	0 comments	Download
M	content/browser/download/download_stats.cc	View	2 chunks	+15 lines, -2 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

asanka

5 years, 5 months ago (2015-07-14 18:04:20 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31fcfe13a5c92618171e40b599920c58f9a2be56.

Expand Messages | Collapse Messages