Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: content/browser/download/download_stats.cc

Issue 1236613003: [Merge to M44] [SafeBrowsing] Send pingbacks for additional file types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2403
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_stats.cc
diff --git a/content/browser/download/download_stats.cc b/content/browser/download/download_stats.cc
index 42bb0754a87ad1bc2649721decefd9db564dbbc2..7b0b9adc1b6e1bb9eed4b4974d66d03bc833f612 100644
--- a/content/browser/download/download_stats.cc
+++ b/content/browser/download/download_stats.cc
@@ -70,6 +70,8 @@ void RecordContentDispositionCountFlag(
// Do not insert, delete, or reorder; this is being histogrammed. Append only.
// All of the download_extensions.cc file types should be in this list.
+// TODO(asanka): This enum and the UMA metrics for dangerous/malicious downloads
+// should be moved to //chrome/browser/download.
const base::FilePath::CharType* kDangerousFileTypes[] = {
FILE_PATH_LITERAL(".ad"),
FILE_PATH_LITERAL(".ade"),
@@ -194,8 +196,19 @@ const base::FilePath::CharType* kDangerousFileTypes[] = {
FILE_PATH_LITERAL(".xhtml"),
FILE_PATH_LITERAL(".xml"),
FILE_PATH_LITERAL(".xsl"),
- FILE_PATH_LITERAL(".xslt")
- FILE_PATH_LITERAL(".website")
+ FILE_PATH_LITERAL(".xslt"),
+ FILE_PATH_LITERAL(".website"),
+ FILE_PATH_LITERAL(".msh1"),
+ FILE_PATH_LITERAL(".msh2"),
+ FILE_PATH_LITERAL(".msh1xml"),
+ FILE_PATH_LITERAL(".msh2xml"),
+ FILE_PATH_LITERAL(".ps1"),
+ FILE_PATH_LITERAL(".ps1xml"),
+ FILE_PATH_LITERAL(".ps2"),
+ FILE_PATH_LITERAL(".ps2xml"),
+ FILE_PATH_LITERAL(".psc1"),
+ FILE_PATH_LITERAL(".psc2"),
+ FILE_PATH_LITERAL(".xnk"),
};
// Maps extensions to their matching UMA histogram int value.
« no previous file with comments | « chrome/common/safe_browsing/download_protection_util.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698