Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1236603002: [arm] CheckConstPool between TF instructions. (Closed)

Created:
5 years, 5 months ago by jbramley
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] CheckConstPool between TF instructions. Some TurboFan instructions block the literal pool for their entire duration. If a long enough sequence of these instructions is encountered, the literal pool can be blocked until it goes out of range. BUG=v8:4292 LOG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbramley
5 years, 5 months ago (2015-07-10 14:21:10 UTC) #2
Benedikt Meurer
LGTM. Although I'd prefer something more robust on the Assembler level.
5 years, 5 months ago (2015-07-13 04:53:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236603002/1
5 years, 5 months ago (2015-07-13 04:53:51 UTC) #5
commit-bot: I haz the power
The author jacob.bramley@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-13 04:53:52 UTC) #6
commit-bot: I haz the power
The author jacob.bramley@arm.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-13 05:00:47 UTC) #7
Benedikt Meurer
5 years, 5 months ago (2015-07-13 05:05:22 UTC) #9
Committing as https://codereview.chromium.org/1232343002 (you used the wrong
account, no CLA).

Powered by Google App Engine
This is Rietveld 408576698