Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1232343002: [arm] CheckConstPool between TurboFan instructions. (Closed)

Created:
5 years, 5 months ago by Benedikt Meurer
Modified:
5 years, 5 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] CheckConstPool between TurboFan instructions. Some TurboFan instructions block the literal pool for their entire duration. If a long enough sequence of these instructions is encountered, the literal pool can be blocked until it goes out of range. Patch from issue 1236603002 at patchset 1 (http://crrev.com/1236603002#ps1). BUG=v8:4292 LOG=y R=jarin@chromium.org Committed: https://crrev.com/3c9c7748c386d967762116de53e31dd1d24f8627 Cr-Commit-Position: refs/heads/master@{#29587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/arm/assembler-arm.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 5 months ago (2015-07-13 05:03:38 UTC) #1
Jarin
lgtm
5 years, 5 months ago (2015-07-13 05:05:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232343002/1
5 years, 5 months ago (2015-07-13 05:05:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 05:26:45 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 05:26:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c9c7748c386d967762116de53e31dd1d24f8627
Cr-Commit-Position: refs/heads/master@{#29587}

Powered by Google App Engine
This is Rietveld 408576698