Final batch adding real histogram values for extension events.

extensions/browser/event_router.cc

Index: extensions/browser/event_router.cc
diff --git a/extensions/browser/event_router.cc b/extensions/browser/event_router.cc
index 7b3792062b1f78df05ea15948e42bbfebd3d5b73..4195be6cd789a571a0441353cd7d08c830dc4cf0 100644
--- a/extensions/browser/event_router.cc
+++ b/extensions/browser/event_router.cc
@@ -797,25 +797,19 @@ void EventRouter::OnExtensionUnloaded(content::BrowserContext* browser_context,
 Event::Event(events::HistogramValue histogram_value,
              const std::string& event_name,
              scoped_ptr<base::ListValue> event_args)
-    : histogram_value(histogram_value),
-      event_name(event_name),
-      event_args(event_args.Pass()),
-      restrict_to_browser_context(NULL),
-      user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
-  DCHECK(this->event_args.get());
-}
+    : Event(histogram_value, event_name, event_args.Pass(), nullptr) {}
 
 Event::Event(events::HistogramValue histogram_value,
              const std::string& event_name,
              scoped_ptr<base::ListValue> event_args,
              BrowserContext* restrict_to_browser_context)
-    : histogram_value(histogram_value),
-      event_name(event_name),
-      event_args(event_args.Pass()),
-      restrict_to_browser_context(restrict_to_browser_context),
-      user_gesture(EventRouter::USER_GESTURE_UNKNOWN) {
-  DCHECK(this->event_args.get());
-}
+    : Event(histogram_value,
+            event_name,
+            event_args.Pass(),
+            restrict_to_browser_context,
+            GURL(),
+            EventRouter::USER_GESTURE_UNKNOWN,
+            EventFilteringInfo()) {}
 
 Event::Event(events::HistogramValue histogram_value,
              const std::string& event_name,
@@ -832,6 +826,12 @@ Event::Event(events::HistogramValue histogram_value,
       user_gesture(user_gesture),
       filter_info(filter_info) {
   DCHECK(this->event_args.get());

[Devlin, 2015/07/21 19:36:25]

nit: seeing this-> hurts my eyes enough to write this comment.  If it hurts
yours enough to change it, great. :)

[not at google - send to devlin, 2015/07/21 20:37:39]

Done, because it bothered me too - but in such a way that will work.

+  DCHECK_NE(events::UNKNOWN, histogram_value)

[not at google - send to devlin, 2015/07/21 18:43:20]

DCHECK added, and changed this to use delegated constructors obviously so that I
don't need to DCHECK in 3 places.

+      << "events::UNKNOWN cannot be used as a histogram value.\n"
+      << "If this is a test, use events::FOR_TEST.\n"
+      << "If this is production code, it is important that you use a realistic "
+      << "value so that we can accurately track event usage. "
+      << "See extension_event_histogram_value.h for inspiration.";
 }
 
 Event::~Event() {}