Final batch adding real histogram values for extension events.

extensions/browser/api/web_request/web_request_api.cc

Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index 88212320ef6a97acc281b35745777b37af4836ee..b704530d367cd3f246f895171a426f68dcc93a6a 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -348,21 +348,24 @@ void SendOnMessageEventOnUI(
 
   extensions::EventFilteringInfo event_filtering_info;
 
+  extensions::events::HistogramValue histogram_value =

[Alexei Svitkine (slow), 2015/07/21 19:09:40]

Nit: Put the anon namespace this is in inside the extensions namespace that the
rest of the code is in, so you can avoid the extensions:: prefix in this code.

[not at google - send to devlin, 2015/07/21 20:37:39]

Done. I just moved the whole-damn-file into the extensions namespace. It's weird
that only part of it is.

+      extensions::events::UNKNOWN;
   std::string event_name;
   // The instance ID uniquely identifies a <webview> instance within an embedder
   // process. We use a filter here so that only event listeners for a particular
   // <webview> will fire.
   if (is_web_view_guest) {
     event_filtering_info.SetInstanceID(web_view_info.instance_id);
+    histogram_value = extensions::events::WEB_VIEW_INTERNAL_ON_MESSAGE;
     event_name = webview::kEventMessage;
   } else {
+    histogram_value = extensions::events::DECLARATIVE_WEB_REQUEST_ON_MESSAGE;
     event_name = declarative_keys::kOnMessage;
   }
 
   scoped_ptr<extensions::Event> event(new extensions::Event(
-      extensions::events::UNKNOWN, event_name, event_args.Pass(),
-      browser_context, GURL(), extensions::EventRouter::USER_GESTURE_UNKNOWN,
-      event_filtering_info));
+      histogram_value, event_name, event_args.Pass(), browser_context, GURL(),
+      extensions::EventRouter::USER_GESTURE_UNKNOWN, event_filtering_info));
   event_router->DispatchEventToExtension(extension_id, event.Pass());
 }