Issue 1236383003: Merge to XFA: Kill Func_Renderpage global function pointer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236383003: Merge to XFA: Kill Func_Renderpage global function pointer. (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Kill Func_Renderpage global function pointer. (cherry picked from commit e3db14f4d0e11ed30bd7e014ffa8cea9d6fb93ad) Original Review URL: https://codereview.chromium.org/1233203004 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/75f43c4c0a733d267122120af26631ded87c8af2

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -64 lines)			Patch
M	fpdfsdk/include/fsdk_define.h	View	1 2	3 chunks	+18 lines, -35 lines	0 comments	Download
M	fpdfsdk/src/fpdf_progressive.cpp	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View		8 chunks	+10 lines, -23 lines	0 comments	Download
M	xfa/include/fwl/adapter/fwl_adaptertimermgr.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Tom Sepez

On 2015/07/15 22:38:38, Tom Sepez wrote: > TBR, small manual merge step. Lei, not TBR, ...

5 years, 5 months ago (2015-07-15 22:48:11 UTC) #2

Tom Sepez

5 years, 5 months ago (2015-07-15 23:35:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
75f43c4c0a733d267122120af26631ded87c8af2 (presubmit successful).