Issue 1233203004: Kill Func_Renderpage global function pointer, it never changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233203004: Kill Func_Renderpage global function pointer, it never changes. (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Kill Func_Renderpage global function pointer, it never changes. Kill some unused macros along the way, and put prototypes in header files. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e3db14f4d0e11ed30bd7e014ffa8cea9d6fb93ad

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -50 lines)			Patch
M	fpdfsdk/include/fsdk_define.h	View		4 chunks	+13 lines, -29 lines	0 comments	Download
M	fpdfsdk/src/fpdf_progressive.cpp	View		2 chunks	+2 lines, -6 lines	0 comments	Download
M	fpdfsdk/src/fpdfview.cpp	View	1	8 chunks	+9 lines, -15 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 5 months ago (2015-07-15 22:30:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e3db14f4d0e11ed30bd7e014ffa8cea9d6fb93ad (presubmit successful).