Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1236263004: Deprecate unused Map/Set FromArray factory methods (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Deprecate unused Map/Set FromArray factory methods These were added when I thought they would be useful in Blink, but as it turned out they were not. They could likely be deleted immediately, but to play it safe I'll go through the usual deprecation process. Committed: https://crrev.com/9aa1dac802112e8fc3c805286c314335edef1bdf Cr-Commit-Position: refs/heads/master@{#29690}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fully deprecated #

Patch Set 3 : Remove calls from cctests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M include/v8.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
adamk
5 years, 5 months ago (2015-07-15 01:21:58 UTC) #2
jochen (gone - plz use gerrit)
lgtm with comment addresed https://codereview.chromium.org/1236263004/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1236263004/diff/1/include/v8.h#newcode3011 include/v8.h:3011: static V8_WARN_UNUSED_RESULT V8_DEPRECATE_SOON( can you ...
5 years, 5 months ago (2015-07-15 13:35:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236263004/20001
5 years, 5 months ago (2015-07-15 15:26:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/2768) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 5 months ago (2015-07-15 15:31:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236263004/40001
5 years, 5 months ago (2015-07-15 19:52:50 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-15 20:17:57 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 20:18:14 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9aa1dac802112e8fc3c805286c314335edef1bdf
Cr-Commit-Position: refs/heads/master@{#29690}

Powered by Google App Engine
This is Rietveld 408576698