Deprecate unused Map/Set FromArray factory methods

test/cctest/test-api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 21717 matching lines @@
   map = v8::Local<v8::Map>::Cast(val);
   CHECK_EQ(2U, map->Size());
 
   v8::Local<v8::Array> contents = map->AsArray();
   CHECK_EQ(4U, contents->Length());
   CHECK_EQ(1, contents->Get(0).As<v8::Int32>()->Value());
   CHECK_EQ(2, contents->Get(1).As<v8::Int32>()->Value());
   CHECK_EQ(3, contents->Get(2).As<v8::Int32>()->Value());
   CHECK_EQ(4, contents->Get(3).As<v8::Int32>()->Value());
 
-  map = v8::Map::FromArray(env.local(), contents).ToLocalChecked();
   CHECK_EQ(2U, map->Size());
 
   CHECK(map->Has(env.local(), v8::Integer::New(isolate, 1)).FromJust());
   CHECK(map->Has(env.local(), v8::Integer::New(isolate, 3)).FromJust());
 
   CHECK(!map->Has(env.local(), v8::Integer::New(isolate, 2)).FromJust());
   CHECK(!map->Has(env.local(), map).FromJust());
 
   CHECK_EQ(2, map->Get(env.local(), v8::Integer::New(isolate, 1))
                   .ToLocalChecked()
@@ skipping 13 matching lines @@
   CHECK(map->Delete(env.local(), map).FromJust());
   CHECK_EQ(2U, map->Size());
   CHECK(!map->Has(env.local(), map).FromJust());
   CHECK(!map->Delete(env.local(), map).FromJust());
 
   map->Clear();
   CHECK_EQ(0U, map->Size());
 }
 
 
-TEST(MapFromArrayOddLength) {
-  v8::Isolate* isolate = CcTest::isolate();
-  v8::HandleScope handle_scope(isolate);
-  LocalContext env;
-  // Odd lengths result in a null MaybeLocal.
-  Local<v8::Array> contents = v8::Array::New(isolate, 41);
-  CHECK(v8::Map::FromArray(env.local(), contents).IsEmpty());
-}
-
-
 TEST(Set) {
   v8::Isolate* isolate = CcTest::isolate();
   v8::HandleScope handle_scope(isolate);
   LocalContext env;
 
   v8::Local<v8::Set> set = v8::Set::New(isolate);
   CHECK(set->IsObject());
   CHECK(set->IsSet());
   CHECK(set->GetPrototype()->StrictEquals(CompileRun("Set.prototype")));
   CHECK_EQ(0U, set->Size());
 
   v8::Local<v8::Value> val = CompileRun("new Set([1, 2])");
   CHECK(val->IsSet());
   set = v8::Local<v8::Set>::Cast(val);
   CHECK_EQ(2U, set->Size());
 
   v8::Local<v8::Array> keys = set->AsArray();
   CHECK_EQ(2U, keys->Length());
   CHECK_EQ(1, keys->Get(0).As<v8::Int32>()->Value());
   CHECK_EQ(2, keys->Get(1).As<v8::Int32>()->Value());
 
-  set = v8::Set::FromArray(env.local(), keys).ToLocalChecked();
   CHECK_EQ(2U, set->Size());
 
   CHECK(set->Has(env.local(), v8::Integer::New(isolate, 1)).FromJust());
   CHECK(set->Has(env.local(), v8::Integer::New(isolate, 2)).FromJust());
 
   CHECK(!set->Has(env.local(), v8::Integer::New(isolate, 3)).FromJust());
   CHECK(!set->Has(env.local(), set).FromJust());
 
   CHECK(!set->Add(env.local(), set).IsEmpty());
   CHECK_EQ(3U, set->Size());
@@ skipping 39 matching lines @@
       "    fake.age;\n"
       "    result = 1;\n"
       "  } catch (e) {\n"
       "  }\n"
       "  test(d+1);\n"
       "}\n"
       "test(0);\n"
       "result;\n",
       0);
 }