bluetooth: Tests refactoring: BaseAdapter, FailStartDiscoveryAdapter...

bluetooth: Tests refactoring: BaseAdapter, FailStartDiscoveryAdapter...

This is the first step towards refactoring our test platform. Add
BaseAdapter and FailStartDiscoveryAdapter and refactor EmptyAdapter and
DiscoverySession.

The design is specified here:
https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit?usp=sharing

Blink-side patch: http://crrev.com/1236583003

BUG=499552
Committed: https://crrev.com/de9541b209c79f002484bcf695de598b863b1699
Cr-Commit-Position: refs/heads/master@{#339687}

[ortuno, 2015-07-15 01:23:12]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-07-15 01:23:13]

@jyasskin: PTAL.

[ortuno, 2015-07-15 23:17:00]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-15 23:17:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236073003/1

[commit-bot: I haz the power, 2015-07-15 23:54:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-15 23:54:43]

Dry run: This issue passed the CQ dry run.

[ortuno, 2015-07-17 17:44:26]

@jyasskin: Updated based on latest design doc changes.

[Jeffrey Yasskin, 2015-07-18 00:18:25]

LGTM

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:57:
// Inhertis from |BaseAdapter|
sp: Inhertis

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:75:
// End of updated code.
Probably comment this something like "The functions after this haven't been
updated to the new design yet."

[ortuno, 2015-07-20 16:55:42]

Thanks!

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:57:
// Inhertis from |BaseAdapter|
On 2015/07/18 at 00:18:25, Jeffrey Yasskin wrote:
> sp: Inhertis

Done.

https://codereview.chromium.org/1236073003/diff/20001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:75:
// End of updated code.
On 2015/07/18 at 00:18:25, Jeffrey Yasskin wrote:
> Probably comment this something like "The functions after this haven't been
updated to the new design yet."

Done.

[ortuno, 2015-07-20 16:55:53]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-07-20 16:55:53]

@scheib: PTAL

[ortuno, 2015-07-20 17:42:09]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-20 17:42:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236073003/40001

[commit-bot: I haz the power, 2015-07-20 18:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 18:10:41]

Dry run: This issue passed the CQ dry run.

[scheib, 2015-07-21 00:25:05]

LGTM

[ortuno, 2015-07-21 17:20:51]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-07-21 17:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org
Link to the patchset: https://codereview.chromium.org/1236073003/#ps40001
(title: "Address jyasskin's comments")

[commit-bot: I haz the power, 2015-07-21 17:21:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236073003/40001

[commit-bot: I haz the power, 2015-07-21 17:34:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-21 17:36:50]

Patchset 3 (id:??) landed as
https://crrev.com/de9541b209c79f002484bcf695de598b863b1699
Cr-Commit-Position: refs/heads/master@{#339687}