Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1230023010: bluetooth: Refactor MultiDeviceAdapter, ScanFilterCheckingAdapter (Closed)

Created:
5 years, 5 months ago by ortuno
Modified:
5 years, 5 months ago
Reviewers:
Jeffrey Yasskin, scheib
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-tests-small-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Refactor MultiDeviceAdapter->GlucoseHeartRateAdapter, ScanFilterCheckingAdapter Also add BaseDevice, BatteryDevice, GlucoseDevice and HeartRateDevice Three sided patch because we need to change the reference to MultiDeviceAdapter in blink: [1] This patch. [2] http://crrev.com/1232123010 [3] http://crrev.com/1244603002 Design doc: https://docs.google.com/document/d/1_QsBzcc84SwF7oaBWbO8rBzn39MISQ3w-6QM9hk0L3E/edit# BUG=499552 Committed: https://crrev.com/ac5b77e8fbe0a6b7959b3b7f1b98cd7d21070a5c Cr-Commit-Position: refs/heads/master@{#339790}

Patch Set 1 : #

Patch Set 2 : Clean up #

Patch Set 3 : #

Patch Set 4 : Move ScanFilterCheckingAdapter to refactored adapters #

Total comments: 2

Patch Set 5 : Fix adapter name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -81 lines) Patch
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 1 2 3 4 5 chunks +96 lines, -24 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 2 3 3 chunks +105 lines, -57 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (10 generated)
ortuno
@jyasskin: PTAL
5 years, 5 months ago (2015-07-16 01:14:51 UTC) #4
ortuno
@jyasskin: Ready for review.
5 years, 5 months ago (2015-07-17 17:45:58 UTC) #7
Jeffrey Yasskin
lgtm
5 years, 5 months ago (2015-07-18 00:40:02 UTC) #8
ortuno
@scheib: PTAL
5 years, 5 months ago (2015-07-20 17:08:31 UTC) #10
scheib
LGTM with fix: https://codereview.chromium.org/1230023010/diff/140001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): https://codereview.chromium.org/1230023010/diff/140001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h#newcode81 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:81: // |MultiDeviceAdapter| GlucoseHeartRateAdapter
5 years, 5 months ago (2015-07-21 00:21:14 UTC) #11
ortuno
Thanks! https://codereview.chromium.org/1230023010/diff/140001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h (right): https://codereview.chromium.org/1230023010/diff/140001/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h#newcode81 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:81: // |MultiDeviceAdapter| On 2015/07/21 at 00:21:13, scheib wrote: ...
5 years, 5 months ago (2015-07-21 21:09:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230023010/160001
5 years, 5 months ago (2015-07-21 21:12:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230023010/160001
5 years, 5 months ago (2015-07-21 23:46:21 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:160001)
5 years, 5 months ago (2015-07-22 00:07:48 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 00:08:47 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ac5b77e8fbe0a6b7959b3b7f1b98cd7d21070a5c
Cr-Commit-Position: refs/heads/master@{#339790}

Powered by Google App Engine
This is Rietveld 408576698