Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 1235983002: [strong] class objects created in strong mode have their prototype frozen (Closed)

Created:
5 years, 5 months ago by conradw
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] class objects created in strong mode have their prototype frozen BUG=v8:3956 LOG=N Committed: https://crrev.com/f996793ec0be128599988671825f469eaf999982 Cr-Commit-Position: refs/heads/master@{#29646}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -28 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/strong/class-object-frozen.js View 3 chunks +38 lines, -20 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
conradw
PTAL
5 years, 5 months ago (2015-07-13 17:12:13 UTC) #2
rossberg
lgtm https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc#newcode1649 src/compiler/ast-graph-builder.cc:1649: // TODO(conradw): It would be more efficient to ...
5 years, 5 months ago (2015-07-14 07:45:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235983002/20001
5 years, 5 months ago (2015-07-14 11:21:16 UTC) #6
conradw
https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1235983002/diff/1/src/compiler/ast-graph-builder.cc#newcode1649 src/compiler/ast-graph-builder.cc:1649: // TODO(conradw): It would be more efficient to define ...
5 years, 5 months ago (2015-07-14 11:21:27 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-14 11:31:43 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 11:31:55 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f996793ec0be128599988671825f469eaf999982
Cr-Commit-Position: refs/heads/master@{#29646}

Powered by Google App Engine
This is Rietveld 408576698