Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: test/mjsunit/strong/class-object-frozen.js

Issue 1235983002: [strong] class objects created in strong mode have their prototype frozen (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x87/full-codegen-x87.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong/class-object-frozen.js
diff --git a/test/mjsunit/strong/class-object-frozen.js b/test/mjsunit/strong/class-object-frozen.js
index 011a11d9fc461b8cd78f64a820e2fb82bb2acde7..2c442c0d5168258986211dd297b7ac05907b459f 100644
--- a/test/mjsunit/strong/class-object-frozen.js
+++ b/test/mjsunit/strong/class-object-frozen.js
@@ -9,25 +9,27 @@
function getClass() {
class Foo {
static get bar() { return 0 }
+ get bar() { return 0 }
}
return Foo;
}
function getClassExpr() {
- return (class { static get bar() { return 0 } });
+ return (class { static get bar() { return 0 } get bar() { return 0 } });
}
function getClassStrong() {
"use strong";
class Foo {
static get bar() { return 0 }
+ get bar() { return 0 }
}
return Foo;
}
function getClassExprStrong() {
"use strong";
- return (class { static get bar() { return 0 } });
+ return (class { static get bar() { return 0 } get bar() { return 0 } });
}
function addProperty(o) {
@@ -39,28 +41,41 @@ function convertPropertyToData(o) {
Object.defineProperty(o, "bar", { value: 1 });
}
-assertDoesNotThrow(function(){addProperty(getClass())});
-assertDoesNotThrow(function(){convertPropertyToData(getClass())});
-assertDoesNotThrow(function(){addProperty(getClassExpr())});
-assertDoesNotThrow(function(){convertPropertyToData(getClassExpr())});
+function testWeakClass(classFunc) {
+ assertDoesNotThrow(function(){addProperty(classFunc())});
+ assertDoesNotThrow(function(){addProperty(classFunc().prototype)});
+ assertDoesNotThrow(function(){convertPropertyToData(classFunc())});
+ assertDoesNotThrow(function(){convertPropertyToData(classFunc().prototype)});
+}
+
+function testStrongClass(classFunc) {
+ assertThrows(function(){addProperty(classFunc())}, TypeError);
+ assertThrows(function(){addProperty(classFunc().prototype)}, TypeError);
+ assertThrows(function(){convertPropertyToData(classFunc())}, TypeError);
+ assertThrows(function(){convertPropertyToData(classFunc().prototype)},
+ TypeError);
+}
+
+testWeakClass(getClass);
+testWeakClass(getClassExpr);
-assertThrows(function(){addProperty(getClassStrong())}, TypeError);
-assertThrows(function(){convertPropertyToData(getClassStrong())}, TypeError);
-assertThrows(function(){addProperty(getClassExprStrong())}, TypeError);
-assertThrows(function(){convertPropertyToData(getClassExprStrong())},
- TypeError);
+testStrongClass(getClassStrong);
+testStrongClass(getClassExprStrong);
// Check strong classes don't freeze their parents.
(function() {
- "use strong";
let parent = getClass();
- class Foo extends parent {
- static get bar() { return 0 }
+ let classFunc = function() {
+ "use strong";
+ class Foo extends parent {
+ static get bar() { return 0 }
+ get bar() { return 0 }
+ }
+ return Foo;
}
- assertThrows(function(){addProperty(Foo)}, TypeError);
- assertThrows(function(){convertPropertyToData(Foo)}, TypeError);
+ testStrongClass(classFunc);
assertDoesNotThrow(function(){addProperty(parent)});
assertDoesNotThrow(function(){convertPropertyToData(parent)});
})();
@@ -69,12 +84,15 @@ assertThrows(function(){convertPropertyToData(getClassExprStrong())},
(function() {
let parent = getClassStrong();
- class Foo extends parent {
- static get bar() { return 0 }
+ let classFunc = function() {
+ class Foo extends parent {
+ static get bar() { return 0 }
+ get bar() { return 0 }
+ }
+ return Foo;
}
assertThrows(function(){addProperty(parent)}, TypeError);
assertThrows(function(){convertPropertyToData(parent)}, TypeError);
- assertDoesNotThrow(function(){addProperty(Foo)});
- assertDoesNotThrow(function(){convertPropertyToData(Foo)});
+ testWeakClass(classFunc);
})();
« no previous file with comments | « src/x87/full-codegen-x87.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698