Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1235943002: Align color keyword handling in CSSParserFastPaths with CSSPropertyParser (Closed)

Created:
5 years, 5 months ago by fs
Modified:
5 years, 5 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Align color keyword handling in CSSParserFastPaths with CSSPropertyParser Previously there has been some discrepancies between CSSParserFastPaths::parseColor and CSSPropertyParser::parseColor with regards which color keywords they accept, and whether they do so in quirks mode or not. Use the same sequence of isColorKeyword and isValueAllowedInMode in both places to try to prevent that happening (again.) BUG=505410 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199021

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M Source/core/css/parser/CSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/CSSParserFastPaths.cpp View 2 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
fs
https://codereview.chromium.org/1235943002/diff/1/Source/core/css/parser/CSSParserFastPaths.cpp File Source/core/css/parser/CSSParserFastPaths.cpp (right): https://codereview.chromium.org/1235943002/diff/1/Source/core/css/parser/CSSParserFastPaths.cpp#newcode438 Source/core/css/parser/CSSParserFastPaths.cpp:438: if (!isValueAllowedInMode(valueID, parserMode)) Could also just have picked HTMLStandardMode/HTMLQuirksMode ...
5 years, 5 months ago (2015-07-13 13:59:28 UTC) #2
Timothy Loh
lgtm
5 years, 5 months ago (2015-07-16 03:20:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235943002/1
5 years, 5 months ago (2015-07-16 08:28:46 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 09:44:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199021

Powered by Google App Engine
This is Rietveld 408576698