Source/core/css/parser/CSSParser.cpp - Issue 1235943002: Align color keyword handling in CSSParserFastPaths with CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParser.cpp

Issue 1235943002: Align color keyword handling in CSSParserFastPaths with CSSPropertyParser (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/CSSParser.cpp

diff --git a/Source/core/css/parser/CSSParser.cpp b/Source/core/css/parser/CSSParser.cpp

index 9b1f173b7787e7e2805fdf08923de1c5e32cf413..42b855aa97fd8e96d2e2cc55aac5edde0b105d44 100644

--- a/Source/core/css/parser/CSSParser.cpp

+++ b/Source/core/css/parser/CSSParser.cpp

@@ -120,7 +120,7 @@ bool CSSParser::parseColor(RGBA32& color, const String& string, bool strict)

return true;

}

- RefPtrWillBeRawPtr<CSSValue> value = CSSParserFastPaths::parseColor(string, !strict);

+ RefPtrWillBeRawPtr<CSSValue> value = CSSParserFastPaths::parseColor(string, strict ? HTMLStandardMode : HTMLQuirksMode);

// TODO(timloh): Why is this always strict mode?

if (!value)

value = parseSingleValue(CSSPropertyColor, string, strictCSSParserContext());