Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: content/public/common/manifest.h

Issue 1235883007: manifest: add theme_color value to the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect change in Blink patch Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.h
diff --git a/content/public/common/manifest.h b/content/public/common/manifest.h
index 43bef5bee75f500d1233d3e80ba23a4a22c8e9c9..6f8f8f4eb405dd52b29cb7d471f71dfd06cb389e 100644
--- a/content/public/common/manifest.h
+++ b/content/public/common/manifest.h
@@ -94,6 +94,9 @@ struct CONTENT_EXPORT Manifest {
// present.
DisplayMode display;
+ // Set to -1 if parsing failed or field is not present.
mlamouri (slow - plz ping) 2015/07/16 12:35:40 Replace -1 by kInvalidOrMissingThemeColor.
Lalit Maganti 2015/07/16 14:49:01 Done
+ int64_t theme_color;
mlamouri (slow - plz ping) 2015/07/16 12:35:40 nit: I'm not sure which order you are following he
Lalit Maganti 2015/07/16 14:49:01 Done.
+
// Set to blink::WebScreenOrientationLockDefault if the parsing failed or the
// field was not present.
blink::WebScreenOrientationLockType orientation;
@@ -121,6 +124,9 @@ struct CONTENT_EXPORT Manifest {
// IPC. The renderer process should truncate the strings before sending the
// Manifest and the browser process must do the same when receiving it.
static const size_t kMaxIPCStringLength;
+
+ // Constant representing an invalid theme color. Set to -1.
+ static const long kInvalidThemeColor;
mlamouri (slow - plz ping) 2015/07/16 12:35:40 kInvalidOrMissingThemeColor maybe? Also, you might
Lalit Maganti 2015/07/16 14:49:01 Done.
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698