manifest: add theme_color value to the manifest

content/public/common/manifest.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_COMMON_MANIFEST_H_
 #define CONTENT_PUBLIC_COMMON_MANIFEST_H_
 
 #include <vector>
 
 #include "base/strings/nullable_string16.h"
@@ skipping 76 matching lines @@
   // Null if the parsing failed or the field was not present.
   base::NullableString16 short_name;
 
   // Empty if the parsing failed or the field was not present.
   GURL start_url;
 
   // Set to DISPLAY_MODE_UNSPECIFIED if the parsing failed or the field was not
   // present.
   DisplayMode display;
 
+  // Set to -1 if parsing failed or field is not present.

[mlamouri (slow - plz ping), 2015/07/16 12:35:40]

Replace -1 by kInvalidOrMissingThemeColor.

[Lalit Maganti, 2015/07/16 14:49:01]

Done

+  int64_t theme_color;

[mlamouri (slow - plz ping), 2015/07/16 12:35:40]

nit: I'm not sure which order you are following here. It's not following the
spec order, nor the alphabetical order. Could you add that before gcm_sender_id?

[Lalit Maganti, 2015/07/16 14:49:01]

Done.

+
   // Set to blink::WebScreenOrientationLockDefault if the parsing failed or the
   // field was not present.
   blink::WebScreenOrientationLockType orientation;
 
   // Empty if the parsing failed, the field was not present, empty or all the
   // icons inside the JSON array were invalid.
   std::vector<Icon> icons;
 
   // Empty if the parsing failed, the field was not present, empty or all the
   // applications inside the array were invalid. The order of the array
   // indicates the priority of the application to use.
   std::vector<RelatedApplication> related_applications;
 
   // A boolean that is used as a hint for the user agent to say that related
   // applications should be preferred over the web application. False if missing
   // or there is a parsing failure.
   bool prefer_related_applications;
 
   // This is a proprietary extension of the web Manifest, double-check that it
   // is okay to use this entry.
   // Null if parsing failed or the field was not present.
   base::NullableString16 gcm_sender_id;
 
   // Maximum length for all the strings inside the Manifest when it is sent over
   // IPC. The renderer process should truncate the strings before sending the
   // Manifest and the browser process must do the same when receiving it.
   static const size_t kMaxIPCStringLength;
+
+  // Constant representing an invalid theme color. Set to -1.
+  static const long kInvalidThemeColor;

[mlamouri (slow - plz ping), 2015/07/16 12:35:40]

kInvalidOrMissingThemeColor maybe? Also, you might want to have the same type as
theme_color, which is int64_t.

[Lalit Maganti, 2015/07/16 14:49:01]

Done.

 };
 
 } // namespace content
 
 #endif // CONTENT_PUBLIC_COMMON_MANIFEST_H_