Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: content/public/common/manifest.cc

Issue 1235883007: manifest: add theme_color value to the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reflect change in Blink patch Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.cc
diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc
index 1345e076b4114f66aaebeaac4dd253df894b5982..471a5952f6a6252636c54cfcf4454a269ed6a193 100644
--- a/content/public/common/manifest.cc
+++ b/content/public/common/manifest.cc
@@ -7,6 +7,7 @@
namespace content {
const double Manifest::Icon::kDefaultDensity = 1;
+const long Manifest::kInvalidThemeColor = -1;
const size_t Manifest::kMaxIPCStringLength = 4 * 1024;
Manifest::Icon::Icon()
@@ -24,6 +25,7 @@ Manifest::RelatedApplication::~RelatedApplication() {
Manifest::Manifest()
: display(DISPLAY_MODE_UNSPECIFIED),
+ theme_color(-1),
mlamouri (slow - plz ping) 2015/07/16 12:35:40 Use the constant.
Lalit Maganti 2015/07/16 14:49:01 Done.
orientation(blink::WebScreenOrientationLockDefault),
prefer_related_applications(false) {
}
@@ -36,6 +38,7 @@ bool Manifest::IsEmpty() const {
short_name.is_null() &&
start_url.is_empty() &&
display == DISPLAY_MODE_UNSPECIFIED &&
+ theme_color == -1 &&
mlamouri (slow - plz ping) 2015/07/16 12:35:40 ditto.
Lalit Maganti 2015/07/16 14:49:01 Done.
orientation == blink::WebScreenOrientationLockDefault &&
icons.empty() &&
related_applications.empty() &&

Powered by Google App Engine
This is Rietveld 408576698