manifest: add theme_color value to the manifest

content/browser/manifest/manifest_manager_host.cc

Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index c22ae0ad46acfd1a4fd4c91c958e3325b55ce4e9..1c0cf3edaa28a895aaf409f29932e46f0fa7e5ac 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -136,6 +136,8 @@ void ManifestManagerHost::OnRequestManifestResponse(
                                    0, Manifest::kMaxIPCStringLength),
                                related_application.id.is_null());
   }
+  if (manifest.theme_color < 0)

[nasko, 2015/07/17 16:36:18]

Can we be a bit more strict? Is it valid for a color value to have the highest
3-4 bytes being non-zero? Why not use a bitmask comparison to ensure we don't
let unexpected values?

[Lalit Maganti, 2015/07/18 17:52:05]

No it is not valid but we do a cast on the renderer side so it would techincally
impossible for this to be the case. I could add the comparison in I guess
because it wouldn't hurt.

[nasko, 2015/07/20 09:22:16]

Please do. What we do in the renderer process is irrelevant, as an exploited
process can do whatever it wants. All parameters received should be verified as
strictly as possible.

+    manifest.theme_color = -1;

[nasko, 2015/07/17 16:36:18]

Please don't use integers, use the symbolic constant you already have defined.

 
   callback->Run(manifest);
   callbacks->Remove(request_id);