manifest: add theme_color value to the manifest

content/browser/manifest/manifest_manager_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/manifest/manifest_manager_host.h"
 
 #include "base/stl_util.h"
 #include "content/common/manifest_manager_messages.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
@@ skipping 118 matching lines @@
             0, Manifest::kMaxIPCStringLength),
         manifest.gcm_sender_id.is_null());
   for (auto& related_application : manifest.related_applications) {
     if (!related_application.url.is_valid())
       related_application.url = GURL();
     related_application.id =
         base::NullableString16(related_application.id.string().substr(
                                    0, Manifest::kMaxIPCStringLength),
                                related_application.id.is_null());
   }
+  if (manifest.theme_color < 0)

[nasko, 2015/07/17 16:36:18]

Can we be a bit more strict? Is it valid for a color value to have the highest
3-4 bytes being non-zero? Why not use a bitmask comparison to ensure we don't
let unexpected values?

[Lalit Maganti, 2015/07/18 17:52:05]

No it is not valid but we do a cast on the renderer side so it would techincally
impossible for this to be the case. I could add the comparison in I guess
because it wouldn't hurt.

[nasko, 2015/07/20 09:22:16]

Please do. What we do in the renderer process is irrelevant, as an exploited
process can do whatever it wants. All parameters received should be verified as
strictly as possible.

+    manifest.theme_color = -1;

[nasko, 2015/07/17 16:36:18]

Please don't use integers, use the symbolic constant you already have defined.

 
   callback->Run(manifest);
   callbacks->Remove(request_id);
   if (callbacks->IsEmpty()) {
     delete callbacks;
     pending_callbacks_.erase(render_frame_host);
   }
 }
 
 } // namespace content