Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 1235813006: Let the analyzer tell you if you've failed to override these methods by making them abstract instea… (Closed)

Created:
5 years, 5 months ago by Hixie
Modified:
5 years, 5 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Let the analyzer tell you if you've failed to override these methods by making them abstract instead of having them default to assert(false) or zero. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b8d39177937f0413b543d37dc3d602323fc9e215

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M sky/sdk/lib/widgets/toggleable.dart View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-13 19:34:50 UTC) #2
Hixie
5 years, 5 months ago (2015-07-14 00:38:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b8d39177937f0413b543d37dc3d602323fc9e215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698