Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Unified Diff: sky/sdk/lib/widgets/toggleable.dart

Issue 1235813006: Let the analyzer tell you if you've failed to override these methods by making them abstract instea… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/toggleable.dart
diff --git a/sky/sdk/lib/widgets/toggleable.dart b/sky/sdk/lib/widgets/toggleable.dart
index 5d5a945e2d7e9552972569fa111e210c97f472e9..c970d70ae36c35966603658ecbfc7402eb0dec2c 100644
--- a/sky/sdk/lib/widgets/toggleable.dart
+++ b/sky/sdk/lib/widgets/toggleable.dart
@@ -58,11 +58,10 @@ abstract class Toggleable extends AnimatedComponent {
onChanged(!value);
}
- // Override these methods to draw yourself
- void customPaintCallback(sky.Canvas canvas, Size size) {
- assert(false);
- }
- Size get size => Size.zero;
+ // Override these to draw yourself
+ void customPaintCallback(sky.Canvas canvas, Size size);
+ Size get size;
+
EdgeDims get margin => const EdgeDims.symmetric(horizontal: 5.0);
double get duration => 200.0;
Curve get curveUp => easeIn;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698