core/src/fxge/win32/fx_win32_dwrite.cpp - Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_dwrite.cpp

Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxge/win32/fx_win32_dwrite.cpp

diff --git a/core/src/fxge/win32/fx_win32_dwrite.cpp b/core/src/fxge/win32/fx_win32_dwrite.cpp

index 28846667e56a8ac968e46109227d6f46d1e514b1..7949888ac27bb370b3934d6be01ec6b038756267 100644

--- a/core/src/fxge/win32/fx_win32_dwrite.cpp

+++ b/core/src/fxge/win32/fx_win32_dwrite.cpp

@@ -266,9 +266,7 @@ FX_BOOL CDWriteExt::DwRendingString(void* renderTarget, CFX_ClipRgn* pClipRgn, F

}

void CDWriteExt::DwDeleteRenderingTarget(void* renderTarget)

{

- if (renderTarget) {

- delete (CDwGdiTextRenderer*)renderTarget;

- }

+ delete (CDwGdiTextRenderer*)renderTarget;

}

void CDWriteExt::DwDeleteFont(void* pFont)

{

« no previous file with comments | « core/src/fxge/win32/fx_win32_device.cpp ('k') | fpdfsdk/src/formfiller/FFL_ComboBox.cpp » ('j') | no next file with comments »