Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1235743004: select attribute for HTMLContentElement should not have [TreatNullAs=NullString] (Closed)

Created:
5 years, 5 months ago by shiva.jm
Modified:
5 years, 5 months ago
Reviewers:
tkent, philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

select attribute for HTMLContentElement should not have [TreatNullAs=NullString] As per spec link: http://w3c.github.io/webcomponents/spec/shadow/#the-content-element, select attribute for HTMLContentElement should not have [TreatNullAs=NullString]. Firefox and IE already suppourts these change. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199277

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Total comments: 5

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
A LayoutTests/fast/dom/content-element-select-null.html View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/html/HTMLContentElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
shiva.jm
pls have a look.
5 years, 5 months ago (2015-07-20 12:06:20 UTC) #2
philipj_slow
https://codereview.chromium.org/1235743004/diff/20001/LayoutTests/fast/dom/content-element-select-null.html File LayoutTests/fast/dom/content-element-select-null.html (right): https://codereview.chromium.org/1235743004/diff/20001/LayoutTests/fast/dom/content-element-select-null.html#newcode2 LayoutTests/fast/dom/content-element-select-null.html:2: <html> It's OK to omit the <html> tag: https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-html-head-body- ...
5 years, 5 months ago (2015-07-20 12:14:39 UTC) #3
shiva.jm
updated the tests and review comments, pls have a look. https://codereview.chromium.org/1235743004/diff/20001/LayoutTests/fast/dom/content-element-select-null.html File LayoutTests/fast/dom/content-element-select-null.html (right): https://codereview.chromium.org/1235743004/diff/20001/LayoutTests/fast/dom/content-element-select-null.html#newcode2 ...
5 years, 5 months ago (2015-07-21 05:02:05 UTC) #4
philipj_slow
lgtm https://codereview.chromium.org/1235743004/diff/40001/LayoutTests/fast/dom/content-element-select-null.html File LayoutTests/fast/dom/content-element-select-null.html (right): https://codereview.chromium.org/1235743004/diff/40001/LayoutTests/fast/dom/content-element-select-null.html#newcode13 LayoutTests/fast/dom/content-element-select-null.html:13: }, ' content element test for select attribute, ...
5 years, 5 months ago (2015-07-21 07:27:20 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235743004/60001
5 years, 5 months ago (2015-07-21 10:15:24 UTC) #7
shiva.jm
updated tests, pls have a look. https://codereview.chromium.org/1235743004/diff/40001/LayoutTests/fast/dom/content-element-select-null.html File LayoutTests/fast/dom/content-element-select-null.html (right): https://codereview.chromium.org/1235743004/diff/40001/LayoutTests/fast/dom/content-element-select-null.html#newcode13 LayoutTests/fast/dom/content-element-select-null.html:13: }, ' content ...
5 years, 5 months ago (2015-07-21 10:47:38 UTC) #9
philipj_slow
lgtm
5 years, 5 months ago (2015-07-21 11:22:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235743004/60001
5 years, 5 months ago (2015-07-21 11:22:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/71916)
5 years, 5 months ago (2015-07-21 12:56:26 UTC) #14
philipj_slow
The inspector/editor/text-editor-ctrl-d.html failure looks like it could be real, it doesn't seem flaky: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector%2Feditor%2Ftext-editor-ctrl-d.html
5 years, 5 months ago (2015-07-21 12:59:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235743004/60001
5 years, 5 months ago (2015-07-22 04:17:11 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=199277
5 years, 5 months ago (2015-07-22 05:08:26 UTC) #18
shiva.jm
5 years, 5 months ago (2015-07-22 05:14:06 UTC) #19
Message was sent while issue was closed. 
On 2015/07/21 12:59:20, philipj wrote:
> The inspector/editor/text-editor-ctrl-d.html failure looks like it could be
> real, it doesn't seem flaky:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ins...

Tried to submit again today, it got submitted, i think other patch has fixed the
test as slow for execution.

Powered by Google App Engine
This is Rietveld 408576698