LayoutTests/fast/dom/content-element-select-null.html - Issue 1235743004: select attribute for HTMLContentElement should not have [TreatNullAs=NullString]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/content-element-select-null.html

Issue 1235743004: select attribute for HTMLContentElement should not have [TreatNullAs=NullString] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>
	philipj_slow 2015/07/20 12:14:38 It's OK to omit the <html> tag: https://www.chromi It's OK to omit the <html> tag: https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... shiva.jm 2015/07/21 05:02:05 Done. Show quoted text On 2015/07/20 12:14:38, philipj wrote: > It's OK to omit the <html> tag: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script>

	6

	7 test(function() {

	8 var element = document.createElement('content');

	9 assert_equals(element.select, '');

	10 element.select = 'null'
	philipj_slow 2015/07/20 12:14:38 This should set null, not the string 'null', in or This should set null, not the string 'null', in order to test the change. shiva.jm 2015/07/21 05:02:05 Done. Show quoted text On 2015/07/20 12:14:38, philipj wrote: > This should set null, not the string 'null', in order to test the change. Done.
	11 assert_equals(element.select, 'null');

	12 element.select = ''
	philipj_slow 2015/07/20 12:14:38 Testing the empty string isn't needed, I think. Th Testing the empty string isn't needed, I think. The test description doesn't mention it either. shiva.jm 2015/07/21 05:02:05 Done. Show quoted text On 2015/07/20 12:14:38, philipj wrote: > Testing the empty string isn't needed, I think. The test description doesn't > mention it either. Done.
	13 assert_equals(element.select, '');

	14 element.select = 'undefined'
	philipj_slow 2015/07/20 12:14:38 Similarly, this should not be the string 'undefine Similarly, this should not be the string 'undefined'. shiva.jm 2015/07/21 05:02:05 Done. Show quoted text On 2015/07/20 12:14:38, philipj wrote: > Similarly, this should not be the string 'undefined'. Done.
	15 assert_equals(element.select, 'undefined');

	16 }, ' content element test for select attribute, null and undefined arguments.');

	17

	18 </script>

	19 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/html/HTMLContentElement.idl » ('j') | no next file with comments »