Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1235713004: mac: Fix os_exchange_data_provider_mac.mm. (Closed)

Created:
5 years, 5 months ago by erikchen
Modified:
5 years, 5 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Fix os_exchange_data_provider_mac.mm. Provider::GetString is intended to return a plain-text representation of the contents of the paste board. On OSX, it was possible for the paste board to contain an NSURL, but not an NSString, and as a result Provider::GetString was incorrectly returning the empty string. This bug manifests itself when Chrome is compiled against the OSX 10.10 SDK. I didn't trace down the exact source of the bug, although it is likely related to https://codereview.chromium.org/1128173004. BUG=463170 Committed: https://crrev.com/5c4eb6866ad14735e16e20b95f34fdea2863259c Cr-Commit-Position: refs/heads/master@{#338405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M ui/base/dragdrop/os_exchange_data.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_mac.mm View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
avi: Please review.
5 years, 5 months ago (2015-07-10 22:48:49 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 5 months ago (2015-07-10 23:13:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235713004/1
5 years, 5 months ago (2015-07-10 23:14:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-11 00:09:04 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 00:10:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c4eb6866ad14735e16e20b95f34fdea2863259c
Cr-Commit-Position: refs/heads/master@{#338405}

Powered by Google App Engine
This is Rietveld 408576698