Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1128173004: Fix a bug in web_drag_dest_mac_unittest.mm. (Closed)

Created:
5 years, 7 months ago by erikchen
Modified:
5 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in web_drag_dest_mac_unittest.mm. The test puts a string representation of a file path into PasteBoard, and then extracts the string again. The logic that extracts the string first converts the string into a file URL. The implementation for that logic in CoreFoundation has different behavior depending on whether Chrome is linked against an OSX 10.9+ SDK. The expectation of the test should compare the string extracted from PasteBoard against the initial string converted into an NSURL, and then back into a string. BUG=484203 Committed: https://crrev.com/cf97bbac4cd96988c47b3cbee228d1c11a6ec9f4 Cr-Commit-Position: refs/heads/master@{#328791}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/browser/web_contents/web_drag_dest_mac_unittest.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
avi: Please review.
5 years, 7 months ago (2015-05-06 23:54:16 UTC) #2
Avi (use Gerrit)
lgtm I'm cool with this.
5 years, 7 months ago (2015-05-07 03:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128173004/20001
5 years, 7 months ago (2015-05-07 17:25:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 17:43:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 17:45:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cf97bbac4cd96988c47b3cbee228d1c11a6ec9f4
Cr-Commit-Position: refs/heads/master@{#328791}

Powered by Google App Engine
This is Rietveld 408576698