Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: sky/tools/setup_dart_analyzer

Issue 1235673002: Fix typos and error handling in setup_dart_analyzer (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/tools/setup-dart-analyzer ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/tools/setup_dart_analyzer
diff --git a/sky/tools/setup-dart-analyzer b/sky/tools/setup_dart_analyzer
similarity index 84%
rename from sky/tools/setup-dart-analyzer
rename to sky/tools/setup_dart_analyzer
index 434774e5a5015526a820b976eddee224c2f12d8c..65e69cc5ac263308da5c62e30db6bf460a5942c5 100755
--- a/sky/tools/setup-dart-analyzer
+++ b/sky/tools/setup_dart_analyzer
@@ -19,8 +19,8 @@ SDK_EXT = os.path.join(SKY_SDK_DIR, 'lib', '_sdkext')
SDK_EXT_TEMPLATE = '''{
"dart:sky": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/dart_sky.dart",
- "dart:sky.internals": "%(build_dir)s/gen/dart-pkg/sky/sky_internals.dart",
- "dart:sky_builtin_natvies": "%(build_dir)s../sdk_ext/builtin_natives.dart"
+ "dart:sky.internals": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/sky_internals.dart",
+ "dart:sky_builtin_natvies": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/builtin_natives.dart"
}'''
def version_for_pubspec(pubspec_path):
@@ -48,6 +48,12 @@ def main():
args = parser.parse_args()
dart_pkg_dir = os.path.join(args.build_dir, 'gen', 'dart-pkg')
+
+ if not os.path.exists(dart_pkg_dir):
+ print 'Cannot find Dart pacakges at "%s".' % dart_pkg_dir
+ print 'Did you run `ninja -C %s sky` ?' % os.path.relpath(args.build_dir, os.getcwd())
+ return 1
+
packages = {}
with open(SKY_PUBSPEC, 'r') as stream:
« no previous file with comments | « sky/tools/setup-dart-analyzer ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698