Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: sky/tools/setup_dart_analyzer

Issue 1235673002: Fix typos and error handling in setup_dart_analyzer (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/tools/setup-dart-analyzer ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import argparse 6 import argparse
7 import subprocess 7 import subprocess
8 import sys 8 import sys
9 import os 9 import os
10 import yaml 10 import yaml
11 11
12 12
13 SKY_TOOLS_DIR = os.path.dirname(os.path.abspath(__file__)) 13 SKY_TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
14 SRC_ROOT = os.path.dirname(os.path.dirname(SKY_TOOLS_DIR)) 14 SRC_ROOT = os.path.dirname(os.path.dirname(SKY_TOOLS_DIR))
15 SKY_SDK_DIR = os.path.join(SRC_ROOT, 'sky', 'sdk') 15 SKY_SDK_DIR = os.path.join(SRC_ROOT, 'sky', 'sdk')
16 SKY_PUBSPEC = os.path.join(SKY_SDK_DIR, 'pubspec.yaml') 16 SKY_PUBSPEC = os.path.join(SKY_SDK_DIR, 'pubspec.yaml')
17 SKY_PUBSPEC_LOCK = os.path.join(SKY_SDK_DIR, 'pubspec.lock') 17 SKY_PUBSPEC_LOCK = os.path.join(SKY_SDK_DIR, 'pubspec.lock')
18 SDK_EXT = os.path.join(SKY_SDK_DIR, 'lib', '_sdkext') 18 SDK_EXT = os.path.join(SKY_SDK_DIR, 'lib', '_sdkext')
19 19
20 SDK_EXT_TEMPLATE = '''{ 20 SDK_EXT_TEMPLATE = '''{
21 "dart:sky": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/dart_sky.dart", 21 "dart:sky": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/dart_sky.dart",
22 "dart:sky.internals": "%(build_dir)s/gen/dart-pkg/sky/sky_internals.dart", 22 "dart:sky.internals": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/sky_internals.da rt",
23 "dart:sky_builtin_natvies": "%(build_dir)s../sdk_ext/builtin_natives.dart" 23 "dart:sky_builtin_natvies": "%(build_dir)s/gen/dart-pkg/sky/sdk_ext/builtin_na tives.dart"
24 }''' 24 }'''
25 25
26 def version_for_pubspec(pubspec_path): 26 def version_for_pubspec(pubspec_path):
27 with open(pubspec_path, 'r') as stream: 27 with open(pubspec_path, 'r') as stream:
28 dependency_spec = yaml.load(stream) 28 dependency_spec = yaml.load(stream)
29 return dependency_spec['version'] 29 return dependency_spec['version']
30 30
31 31
32 def entry_for_dependency(dart_pkg_dir, dependency): 32 def entry_for_dependency(dart_pkg_dir, dependency):
33 dependency_path = os.path.join(dart_pkg_dir, dependency) 33 dependency_path = os.path.join(dart_pkg_dir, dependency)
34 version = version_for_pubspec(os.path.join(dependency_path, 'pubspec.yaml')) 34 version = version_for_pubspec(os.path.join(dependency_path, 'pubspec.yaml'))
35 return { 35 return {
36 'description': { 36 'description': {
37 'path': os.path.relpath(dependency_path, SKY_SDK_DIR), 37 'path': os.path.relpath(dependency_path, SKY_SDK_DIR),
38 'relative': True, 38 'relative': True,
39 }, 39 },
40 'source': 'path', 40 'source': 'path',
41 'version': version, 41 'version': version,
42 } 42 }
43 43
44 44
45 def main(): 45 def main():
46 parser = argparse.ArgumentParser(description='Adds files to the source tree to make the dart analyzer happy') 46 parser = argparse.ArgumentParser(description='Adds files to the source tree to make the dart analyzer happy')
47 parser.add_argument('build_dir', type=str, help='Path the build directory to use for build artifacts') 47 parser.add_argument('build_dir', type=str, help='Path the build directory to use for build artifacts')
48 args = parser.parse_args() 48 args = parser.parse_args()
49 49
50 dart_pkg_dir = os.path.join(args.build_dir, 'gen', 'dart-pkg') 50 dart_pkg_dir = os.path.join(args.build_dir, 'gen', 'dart-pkg')
51
52 if not os.path.exists(dart_pkg_dir):
53 print 'Cannot find Dart pacakges at "%s".' % dart_pkg_dir
54 print 'Did you run `ninja -C %s sky` ?' % os.path.relpath(args.build_dir , os.getcwd())
55 return 1
56
51 packages = {} 57 packages = {}
52 58
53 with open(SKY_PUBSPEC, 'r') as stream: 59 with open(SKY_PUBSPEC, 'r') as stream:
54 spec = yaml.load(stream) 60 spec = yaml.load(stream)
55 for dependency in spec['dependencies'].keys(): 61 for dependency in spec['dependencies'].keys():
56 packages[dependency] = entry_for_dependency(dart_pkg_dir, dependency ) 62 packages[dependency] = entry_for_dependency(dart_pkg_dir, dependency )
57 63
58 lock = { 'packages': packages } 64 lock = { 'packages': packages }
59 with open(SKY_PUBSPEC_LOCK, 'w') as stream: 65 with open(SKY_PUBSPEC_LOCK, 'w') as stream:
60 yaml.dump(lock, stream=stream, default_flow_style=False) 66 yaml.dump(lock, stream=stream, default_flow_style=False)
61 67
62 with open(SDK_EXT, 'w') as stream: 68 with open(SDK_EXT, 'w') as stream:
63 rebased_build_dir = os.path.relpath(args.build_dir, os.path.dirname(SDK_ EXT)) 69 rebased_build_dir = os.path.relpath(args.build_dir, os.path.dirname(SDK_ EXT))
64 stream.write(SDK_EXT_TEMPLATE % { 'build_dir': rebased_build_dir }) 70 stream.write(SDK_EXT_TEMPLATE % { 'build_dir': rebased_build_dir })
65 71
66 72
67 if __name__ == '__main__': 73 if __name__ == '__main__':
68 sys.exit(main()) 74 sys.exit(main())
OLDNEW
« no previous file with comments | « sky/tools/setup-dart-analyzer ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698