Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1235603004: Reland of "Make d8 stop using to-be-deprecated APIs" (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "Make d8 stop using to-be-deprecated APIs" Original issue's description: > BUG=v8:4134 > LOG=n > R=yangguo@chromium.org > > Review URL: https://codereview.chromium.org/1239053004 BUG=v8:4134 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/d180390f7f44e95a0808d0cd67da71504f63d864 Cr-Commit-Position: refs/heads/master@{#29742}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -341 lines) Patch
M src/d8.h View 9 chunks +17 lines, -18 lines 0 comments Download
M src/d8.cc View 1 54 chunks +341 lines, -214 lines 0 comments Download
M src/d8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/d8-debug.cc View 4 chunks +49 lines, -28 lines 0 comments Download
M src/d8-posix.cc View 28 chunks +137 lines, -72 lines 0 comments Download
M src/d8-readline.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
ptal 1st patchset is original 2nd patchset includes fix
5 years, 5 months ago (2015-07-20 06:43:05 UTC) #1
Yang
On 2015/07/20 06:43:05, jochen wrote: > ptal > > 1st patchset is original > 2nd ...
5 years, 5 months ago (2015-07-20 06:55:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235603004/20001
5 years, 5 months ago (2015-07-20 06:56:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-20 07:05:46 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 07:06:02 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d180390f7f44e95a0808d0cd67da71504f63d864
Cr-Commit-Position: refs/heads/master@{#29742}

Powered by Google App Engine
This is Rietveld 408576698