Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1239053004: Make d8 stop using to-be-deprecated APIs (Closed)

Created:
5 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 5 months ago
Reviewers:
Yang, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make d8 stop using to-be-deprecated APIs BUG=v8:4134 LOG=n R=yangguo@chromium.org Committed: https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 Cr-Commit-Position: refs/heads/master@{#29726}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+555 lines, -340 lines) Patch
M src/d8.h View 9 chunks +17 lines, -18 lines 0 comments Download
M src/d8.cc View 1 2 54 chunks +340 lines, -213 lines 0 comments Download
M src/d8.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/d8-debug.cc View 4 chunks +49 lines, -28 lines 0 comments Download
M src/d8-posix.cc View 1 28 chunks +137 lines, -72 lines 0 comments Download
M src/d8-readline.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jochen (gone - plz use gerrit)
ptal
5 years, 5 months ago (2015-07-17 12:19:52 UTC) #1
Yang
On 2015/07/17 12:19:52, jochen wrote: > ptal lgtm.
5 years, 5 months ago (2015-07-17 12:25:43 UTC) #2
jochen (gone - plz use gerrit)
I'm using this CL to try and see whether the CQ refuses BUG=foo
5 years, 5 months ago (2015-07-17 12:36:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239053004/40001
5 years, 5 months ago (2015-07-17 12:36:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/4284)
5 years, 5 months ago (2015-07-17 12:39:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239053004/40001
5 years, 5 months ago (2015-07-17 12:43:50 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-17 12:44:54 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/af82ef84b4f851411f00e69167ab29382c7499b8 Cr-Commit-Position: refs/heads/master@{#29726}
5 years, 5 months ago (2015-07-17 12:45:16 UTC) #12
Michael Achenbach
5 years, 5 months ago (2015-07-17 13:53:15 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1240993003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug%20-%20c....

Powered by Google App Engine
This is Rietveld 408576698