Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3270)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java

Issue 1235523003: Standardize parameters passed when Tabs are created asynchronously. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java
index 58dd0e4d40718f604f755e13589c6b4002cb5488..87d6146f74aa87e061c30bce33c25f31ea10e8ac 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeTabbedActivityLollipopAndAboveTest.java
@@ -15,12 +15,13 @@ import org.chromium.base.test.util.MinAndroidSdkLevel;
import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.browser.document.ChromeLauncherActivity;
import org.chromium.chrome.browser.document.DocumentActivity;
-import org.chromium.chrome.browser.document.DocumentMetricIds;
+import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
import org.chromium.chrome.test.util.ActivityUtils;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
+import org.chromium.content_public.browser.LoadUrlParams;
import java.lang.ref.WeakReference;
import java.util.List;
@@ -54,9 +55,9 @@ public class ChromeTabbedActivityLollipopAndAboveTest extends ChromeTabbedActivi
ThreadUtils.runOnUiThreadBlocking(new Runnable() {
@Override
public void run() {
- ChromeLauncherActivity.launchDocumentInstance(null, false,
- ChromeLauncherActivity.LAUNCH_MODE_FOREGROUND, "about:blank",
- DocumentMetricIds.STARTED_BY_UNKNOWN, 0, null);
+ AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(
+ new LoadUrlParams("about:blank"));
+ ChromeLauncherActivity.launchDocumentInstance(null, false, asyncParams);
}
});
}

Powered by Google App Engine
This is Rietveld 408576698