Change ChunkDemuxerStream/SourceBufferStream memory limit to size_t type

media/filters/chunk_demuxer.h

Index: media/filters/chunk_demuxer.h
diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h
index cdf2e524c812e906459ee7b7136f39520fd1e60a..d18a218722cfcce508c6fdd28b6fe7461979abd4 100644
--- a/media/filters/chunk_demuxer.h
+++ b/media/filters/chunk_demuxer.h
@@ -11,6 +11,7 @@
 #include <utility>
 #include <vector>
 
+#include "base/basictypes.h"
 #include "base/synchronization/lock.h"
 #include "media/base/byte_queue.h"
 #include "media/base/demuxer.h"
@@ -94,9 +95,7 @@ class MEDIA_EXPORT ChunkDemuxerStream : public DemuxerStream {
   TextTrackConfig text_track_config();
 
   // Sets the memory limit, in bytes, on the SourceBufferStream.
-  void set_memory_limit(int memory_limit) {
-    stream_->set_memory_limit(memory_limit);
-  }
+  void SetMemoryLimit(size_t memory_limit);

[ddorwin, 2015/07/20 21:23:57]

Set*Stream*MemoryLimit?

[servolk, 2015/07/22 19:02:11]

I think it's pretty obvious from the context where this is called, that this is
for a stream. What's the point of repeating that?

[ddorwin, 2015/07/22 22:48:08]

A class/API should be self-documenting and standalone. A reader shouldn't need
to look for existing call sites (or the implementation) to figure out what it
means. Also, comments should generally be unnecessary because functions should
be self-documenting.

[servolk, 2015/07/22 23:04:54]

Done.

 
   bool supports_partial_append_window_trimming() const {
     return partial_append_window_trimming_enabled_;
@@ -277,7 +276,7 @@ class MEDIA_EXPORT ChunkDemuxer : public Demuxer {
   // Sets the memory limit on each stream of a specific type.
   // |memory_limit| is the maximum number of bytes each stream of type |type|
   // is allowed to hold in its buffer.
-  void SetMemoryLimits(DemuxerStream::Type type, int memory_limit);
+  void SetMemoryLimits(DemuxerStream::Type type, size_t memory_limit);
 
   // Returns the ranges representing the buffered data in the demuxer.
   // TODO(wolenetz): Remove this method once MediaSourceDelegate no longer