Change ChunkDemuxerStream/SourceBufferStream memory limit to size_t type

media/filters/chunk_demuxer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_CHUNK_DEMUXER_H_
 #define MEDIA_FILTERS_CHUNK_DEMUXER_H_
 
 #include <deque>
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
 
+#include "base/basictypes.h"
 #include "base/synchronization/lock.h"
 #include "media/base/byte_queue.h"
 #include "media/base/demuxer.h"
 #include "media/base/demuxer_stream.h"
 #include "media/base/ranges.h"
 #include "media/base/stream_parser.h"
 #include "media/filters/source_buffer_stream.h"
 
 namespace media {
 
@@ skipping 63 matching lines @@
   AudioDecoderConfig audio_decoder_config() override;
   VideoDecoderConfig video_decoder_config() override;
   bool SupportsConfigChanges() override;
   VideoRotation video_rotation() override;
 
   // Returns the text track configuration.  It is an error to call this method
   // if type() != TEXT.
   TextTrackConfig text_track_config();
 
   // Sets the memory limit, in bytes, on the SourceBufferStream.
-  void set_memory_limit(int memory_limit) {
-    stream_->set_memory_limit(memory_limit);
-  }
+  void SetMemoryLimit(size_t memory_limit);

[ddorwin, 2015/07/20 21:23:57]

Set*Stream*MemoryLimit?

[servolk, 2015/07/22 19:02:11]

I think it's pretty obvious from the context where this is called, that this is
for a stream. What's the point of repeating that?

[ddorwin, 2015/07/22 22:48:08]

A class/API should be self-documenting and standalone. A reader shouldn't need
to look for existing call sites (or the implementation) to figure out what it
means. Also, comments should generally be unnecessary because functions should
be self-documenting.

[servolk, 2015/07/22 23:04:54]

Done.

 
   bool supports_partial_append_window_trimming() const {
     return partial_append_window_trimming_enabled_;
   }
 
   void SetLiveness(Liveness liveness);
 
  private:
   enum State {
     UNINITIALIZED,
@@ skipping 160 matching lines @@
   // state. UnmarkEndOfStream() must not be called if a matching
   // MarkEndOfStream() has not come before it.
   void MarkEndOfStream(PipelineStatus status);
   void UnmarkEndOfStream();
 
   void Shutdown();
 
   // Sets the memory limit on each stream of a specific type.
   // |memory_limit| is the maximum number of bytes each stream of type |type|
   // is allowed to hold in its buffer.
-  void SetMemoryLimits(DemuxerStream::Type type, int memory_limit);
+  void SetMemoryLimits(DemuxerStream::Type type, size_t memory_limit);
 
   // Returns the ranges representing the buffered data in the demuxer.
   // TODO(wolenetz): Remove this method once MediaSourceDelegate no longer
   // requires it for doing hack browser seeks to I-frame on Android. See
   // http://crbug.com/304234.
   Ranges<base::TimeDelta> GetBufferedRanges() const;
 
  private:
   enum State {
     WAITING_FOR_INIT,
@@ skipping 107 matching lines @@
 
   // Indicates that splice frame generation is enabled.
   const bool splice_frames_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(ChunkDemuxer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_CHUNK_DEMUXER_H_