Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 1235253007: Revert of [handles] Sanitize Handle and friends. (Closed)

Created:
5 years, 5 months ago by Michael Achenbach
Modified:
5 years, 5 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [handles] Sanitize Handle and friends. (patchset #5 id:180001 of https://codereview.chromium.org/1128533002/) Reason for revert: [Sheriff] Still breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/2066 Original issue's description: > [handles] Sanitize Handle and friends. > > Bunch of cleanups to allow us to get rid of handles-inl.h at some > point (in the not so far future); but more importantly to sanitize uses > of handles and prepare for handle canonicalization support. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 > Cr-Commit-Position: refs/heads/master@{#28222} > > Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 > Cr-Commit-Position: refs/heads/master@{#29666} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1964b19663157f948409eedd958eb10e4f80e193 Cr-Commit-Position: refs/heads/master@{#29669}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -213 lines) Patch
M src/api.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/handles.h View 7 chunks +138 lines, -176 lines 0 comments Download
M src/handles.cc View 2 chunks +1 line, -29 lines 0 comments Download
M src/handles-inl.h View 5 chunks +70 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [handles] Sanitize Handle and friends.
5 years, 5 months ago (2015-07-15 08:05:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235253007/1
5 years, 5 months ago (2015-07-15 08:05:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 08:05:49 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1964b19663157f948409eedd958eb10e4f80e193 Cr-Commit-Position: refs/heads/master@{#29669}
5 years, 5 months ago (2015-07-15 08:06:08 UTC) #4
Michael Achenbach
5 years, 5 months ago (2015-07-15 08:06:29 UTC) #5
Message was sent while issue was closed.
https://paste.googleplex.com/4739237941346304

Powered by Google App Engine
This is Rietveld 408576698