src/api.cc - Issue 1235253007: Revert of [handles] Sanitize Handle and friends.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1235253007: Revert of [handles] Sanitize Handle and friends. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index e2abb98ff92dd948e9288e1ba7a188c837122a8d..79f8247125ecc74eb307e5bad0d3064d9640451d 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3797,8 +3797,7 @@

isolate, self, toStringTag).ToHandle(&tag);

RETURN_ON_FAILED_EXECUTION(String);

if (tag->IsString()) {

- class_name = Utils::OpenHandle(*handle_scope.Escape(

- Utils::ToLocal(i::Handle<i::String>::cast(tag))));

+ class_name = i::Handle<i::String>::cast(tag).EscapeFrom(&handle_scope);

}

const char* prefix = "[object ";

« no previous file with comments | « src/api.h ('k') | src/handles.h » ('j') | no next file with comments »