Issue 1235233004: Make the popup menu width animation work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235233004: Make the popup menu width animation work (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make the popup menu width animation work Previously, the scrollable classes were adding a material, which created a background that obscured the menu background. This CL removes that background and improves the animation parameters for the popup menu. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7464958bea88744dd25aaf1cacc3400f31545126

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -21 lines)			Patch
M	sky/sdk/example/stocks/lib/stock_list.dart	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/widgets/fixed_height_scrollable.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/popup_menu.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	sky/sdk/lib/widgets/scrollable.dart	View	4 chunks	+1 line, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-14 20:19:15 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7464958bea88744dd25aaf1cacc3400f31545126 (presubmit successful).