Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: sky/sdk/lib/widgets/scrollable.dart

Issue 1235233004: Make the popup menu width animation work (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/widgets/scrollable.dart
diff --git a/sky/sdk/lib/widgets/scrollable.dart b/sky/sdk/lib/widgets/scrollable.dart
index 807bd26a963dfc019d30154d001e211a8eb31674..1195a6a9b860a0d6bd856cc47ff1bca53bf6c495 100644
--- a/sky/sdk/lib/widgets/scrollable.dart
+++ b/sky/sdk/lib/widgets/scrollable.dart
@@ -9,7 +9,6 @@ import 'package:sky/animation/animated_simulation.dart';
import 'package:sky/animation/scroll_behavior.dart';
import 'package:sky/theme/view_configuration.dart' as config;
import 'package:sky/widgets/basic.dart';
-import 'package:sky/widgets/material.dart';
const double _kMillisecondsPerSecond = 1000.0;
@@ -28,11 +27,9 @@ abstract class Scrollable extends StatefulComponent {
Scrollable({
String key,
- this.backgroundColor,
this.direction: ScrollDirection.vertical
}) : super(key: key);
- Color backgroundColor;
ScrollDirection direction;
void initState() {
@@ -40,7 +37,6 @@ abstract class Scrollable extends StatefulComponent {
}
void syncFields(Scrollable source) {
- backgroundColor = source.backgroundColor;
direction == source.direction;
}
@@ -61,11 +57,7 @@ abstract class Scrollable extends StatefulComponent {
Widget build() {
return new Listener(
- child: new Material(
- type: MaterialType.canvas,
- child: buildContent(),
- color: backgroundColor
- ),
+ child: buildContent(),
onPointerDown: _handlePointerDown,
onPointerUp: _handlePointerUpOrCancel,
onPointerCancel: _handlePointerUpOrCancel,
« no previous file with comments | « sky/sdk/lib/widgets/popup_menu.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698