Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1235213004: Blob/File constructors/slice method shouldn't throw on invalid types (Closed)

Created:
5 years, 5 months ago by jsbell
Modified:
5 years, 3 months ago
Reviewers:
kinuko
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Blob/File constructors/slice method shouldn't throw on invalid types Per spec[1] and tests[2] the constructors for Blob and File and their slice() methods should not throw if non-ASCII type is supplied; instead it should use "" as the type. In addition, the type should be consistently lower-cased, by both the constructors and slice() method. [1] https://w3c.github.io/FileAPI/ [2] https://github.com/w3c/web-platform-tests/tree/master/FileAPI BUG=509786 R=kinuko@chromium.org

Patch Set 1 #

Patch Set 2 : Don't mess with programmatically set types #

Patch Set 3 : Remove debugging spew #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M LayoutTests/fast/files/blob-constructor.html View 2 chunks +6 lines, -1 line 0 comments Download
M LayoutTests/fast/files/blob-constructor-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/files/file-constructor.html View 1 chunk +6 lines, -1 line 0 comments Download
M LayoutTests/fast/files/file-constructor-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/post-blob-content-type-tests.js View 1 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/FileAPI/blob/Blob-slice-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/web-platform-tests/FileAPI/file/File-constructor-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/imported/web-platform-tests/FileAPI/blob/Blob-constructor-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fileapi/Blob.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/fileapi/File.cpp View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
5 years, 3 months ago (2015-09-23 17:34:11 UTC) #1

Powered by Google App Engine
This is Rietveld 408576698