Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: LayoutTests/fast/files/blob-constructor.html

Issue 1235213004: Blob/File constructors/slice method shouldn't throw on invalid types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Remove debugging spew Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/fast/files/blob-constructor-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/files/blob-constructor.html
diff --git a/LayoutTests/fast/files/blob-constructor.html b/LayoutTests/fast/files/blob-constructor.html
index a85627d6ffc8f2cd26a56fc9b78ccc70c1f3abc8..16b012afa61a5a8cf43e6d9863c2cd266846d701 100644
--- a/LayoutTests/fast/files/blob-constructor.html
+++ b/LayoutTests/fast/files/blob-constructor.html
@@ -42,7 +42,6 @@ shouldBeTrue("(new Blob([], {unknownKey:'value'})) instanceof window.Blob");
shouldThrow("new Blob([], {endings:'illegalValue'})", "'TypeError: Failed to construct \\'Blob\\': The provided value \\'illegalValue\\' is not a valid enum value of type NormalizeLineEndings.'");
shouldThrow("new Blob([], {endings:throwingObj})", "'Error'");
shouldThrow("new Blob([], {type:throwingObj})", "'Error'");
-shouldThrow("new Blob([], {type:'hello\u00EE'})", "'SyntaxError: Failed to construct \\'Blob\\': The \\'type\\' property must consist of ASCII characters.'");
// Test that order of property bag evaluation is lexigraphical
var throwingObj1 = { toString: function() { throw "Error 1"; } };
@@ -51,6 +50,12 @@ shouldThrow("new Blob([], {endings:throwingObj1, type:throwingObj2})", "'Error 1
shouldThrow("new Blob([], {type:throwingObj2, endings:throwingObj1})", "'Error 1'");
shouldThrow("new Blob([], {type:throwingObj2, endings:'illegal'})", "'TypeError: Failed to construct \\'Blob\\': The provided value \\'illegal\\' is not a valid enum value of type NormalizeLineEndings.'");
+// Test non-ASCII type handling
+shouldBeEqualToString("new Blob([], {type:'hello\u00EE'}).type", "");
+
+// Test lowercasing of type
+shouldBeEqualToString("new Blob([], {type:'123ABCabc'}).type", "123abcabc");
+
// Test various non-object literals being used as property bags.
shouldBeTrue("(new Blob([], null)) instanceof window.Blob");
shouldBeTrue("(new Blob([], undefined)) instanceof window.Blob");
« no previous file with comments | « no previous file | LayoutTests/fast/files/blob-constructor-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698