Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1235153008: Added GLVec4ScalarBench that doesn't use VAOs (Closed)

Created:
5 years, 5 months ago by wangyix
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Added GLVec4ScalarBench that doesn't use VAOs BUG=skia: Committed: https://skia.googlesource.com/skia/+/891f0f35db5c805f57fe070a2f2b515c612eecca

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -0 lines) Patch
A bench/GLVec4ScalarBench.cpp View 1 1 chunk +303 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tomhudson
lgtm
5 years, 5 months ago (2015-07-15 19:18:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235153008/20001
5 years, 5 months ago (2015-07-15 19:18:47 UTC) #4
wangyix
I removed all the VAO commands from this bench; it passed the debug and release ...
5 years, 5 months ago (2015-07-15 19:19:37 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 19:26:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/891f0f35db5c805f57fe070a2f2b515c612eecca

Powered by Google App Engine
This is Rietveld 408576698