Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: content/child/service_worker/service_worker_dispatcher.cc

Issue 1235083006: CallbackPromiseAdapter types should be more compatible with WebCallbacks (2/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@web-callbacks-3
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/renderer/bluetooth/bluetooth_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.cc
diff --git a/content/child/service_worker/service_worker_dispatcher.cc b/content/child/service_worker/service_worker_dispatcher.cc
index 1a8244258aff252e023658906df5b8b7678b4f08..6e9ecb402be63bb87af21b6a0b114cc76ddc6d87 100644
--- a/content/child/service_worker/service_worker_dispatcher.cc
+++ b/content/child/service_worker/service_worker_dispatcher.cc
@@ -423,7 +423,7 @@ void ServiceWorkerDispatcher::OnUnregistered(int thread_id,
DCHECK(callbacks);
if (!callbacks)
return;
- callbacks->onSuccess(&is_success);
+ callbacks->onSuccess(is_success);
pending_unregistration_callbacks_.Remove(request_id);
}
@@ -557,7 +557,7 @@ void ServiceWorkerDispatcher::OnUpdateError(
if (!callbacks)
return;
- callbacks->onError(new WebServiceWorkerError(error_type, message));
+ callbacks->onError(WebServiceWorkerError(error_type, message));
pending_update_callbacks_.Remove(request_id);
}
@@ -580,9 +580,7 @@ void ServiceWorkerDispatcher::OnUnregistrationError(
if (!callbacks)
return;
- scoped_ptr<WebServiceWorkerError> error(
- new WebServiceWorkerError(error_type, message));
- callbacks->onError(error.release());
+ callbacks->onError(WebServiceWorkerError(error_type, message));
pending_unregistration_callbacks_.Remove(request_id);
}
« no previous file with comments | « content/child/push_messaging/push_provider.cc ('k') | content/renderer/bluetooth/bluetooth_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698