Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1235083006: CallbackPromiseAdapter types should be more compatible with WebCallbacks (2/3). (Closed)

Created:
5 years, 5 months ago by yhirano
Modified:
5 years, 4 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, mlamouri+watch-content_chromium.org, kinuko+watch, tzik, johnme+watch_chromium.org, serviceworker-reviews, jam, nhiroki, mvanouwerkerk+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/src.git@web-callbacks-3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CallbackPromiseAdapter types should be more compatible with WebCallbacks (2/3). This series of CLs makes CallbackPromiseAdapter (CPA) more compatible with WebCallbacks (WC) in terms of type parameters. Before this CL, CPA<S, T> corresponded to WC<S::WebType*, T::WebType*>. CPAs took ownership of passed pointers but there was no place to represent that in WebCallbacks. This series of CLs changes that: CPA<S, T> correspond to WC<S::WebType, T::WebType>. CPA users can specify if he/she wants the parameter ownership by specifying the type parameter. For example, setting S::WebType to OwnPtr<X> means it takes ownership. Setting S::WebType to |const X&| means it doesn't take ownership. WebCallbacks is exposed to chromium side, so we use WebPassOwnPtr as the counterpart of PassOwnPtr. [1] https://codereview.chromium.org/1234603003/ [2] This CL. [3] https://codereview.chromium.org/1240763002/ BUG=493531 Committed: https://crrev.com/7f862b475953a0d6a1af42f27adf38062fe11b10 Cr-Commit-Position: refs/heads/master@{#342577}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -70 lines) Patch
M content/child/geofencing/geofencing_dispatcher.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 2 3 4 5 2 chunks +4 lines, -5 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M content/renderer/bluetooth/bluetooth_dispatcher.cc View 1 2 3 4 5 6 7 8 12 chunks +18 lines, -17 lines 0 comments Download
M content/renderer/cache_storage/cache_storage_dispatcher.cc View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 2 3 4 5 6 7 4 chunks +6 lines, -5 lines 0 comments Download
M content/renderer/service_worker/service_worker_context_client.cc View 1 2 3 4 5 6 8 chunks +17 lines, -25 lines 0 comments Download

Messages

Total messages: 28 (11 generated)
yhirano
5 years, 5 months ago (2015-07-15 06:18:28 UTC) #2
kinuko
lgtm
5 years, 5 months ago (2015-07-26 15:15:18 UTC) #3
yhirano
PTAL. mlamouri@ for app_banner, presentation mvanouwerkerk@ for push_messaging scheib@ for bluetooth mek@ for geofencing. peter@ ...
5 years, 4 months ago (2015-07-27 12:38:57 UTC) #5
Peter Beverloo
Ooh nice :) push and notifications lgtm
5 years, 4 months ago (2015-07-27 12:53:01 UTC) #6
Marijn Kruisselbrink
geofencing LGTM
5 years, 4 months ago (2015-07-27 16:58:37 UTC) #7
scheib
bluetooth LGTM
5 years, 4 months ago (2015-07-27 17:29:25 UTC) #8
Michael van Ouwerkerk
push_messaging lgtm
5 years, 4 months ago (2015-07-28 10:14:58 UTC) #9
yhirano
I reverted app_banner related changes because it no longer uses CallbackPromiseAdapter. avavyvod@, can you take ...
5 years, 4 months ago (2015-07-29 04:05:00 UTC) #11
yhirano
On 2015/07/29 04:05:00, yhirano wrote: > I reverted app_banner related changes because it no longer ...
5 years, 4 months ago (2015-08-04 03:36:39 UTC) #12
whywhat
On 2015/08/04 at 03:36:39, yhirano wrote: > On 2015/07/29 04:05:00, yhirano wrote: > > I ...
5 years, 4 months ago (2015-08-05 12:45:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083006/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1235083006/100001
5 years, 4 months ago (2015-08-07 11:12:16 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/54216) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-07 11:13:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083006/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1235083006/140001
5 years, 4 months ago (2015-08-10 01:32:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/26212)
5 years, 4 months ago (2015-08-10 02:05:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235083006/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1235083006/160001
5 years, 4 months ago (2015-08-10 03:38:00 UTC) #26
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-10 04:29:13 UTC) #27
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 04:29:50 UTC) #28
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/7f862b475953a0d6a1af42f27adf38062fe11b10
Cr-Commit-Position: refs/heads/master@{#342577}

Powered by Google App Engine
This is Rietveld 408576698