Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1235033008: Remove /fallback flag from 32-bit clang-cl invocations and enable -Werror (Closed)

Created:
5 years, 5 months ago by Reid Kleckner
Modified:
5 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove /fallback flag from 32-bit clang-cl invocations and enable -Werror Clang can now compile all of Chromium in 32-bit as well as 64-bit without warnings. R=thakis@chromium.org BUG=82385 Committed: https://crrev.com/b5d0897658e728ea186c057ec414d53176913b2f Cr-Commit-Position: refs/heads/master@{#339178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Reid Kleckner
5 years, 5 months ago (2015-07-14 17:50:01 UTC) #1
Nico
We need to land that roll first.
5 years, 5 months ago (2015-07-14 17:52:06 UTC) #2
Nico
(if you feel like it, `git cl patch -b rollclang 1234713002`, then change the revision ...
5 years, 5 months ago (2015-07-14 17:54:08 UTC) #3
chromium-reviews
Cool, I'm running it. On Tue, Jul 14, 2015 at 10:54 AM, <thakis@chromium.org> wrote: > ...
5 years, 5 months ago (2015-07-14 18:17:59 UTC) #4
Reid Kleckner
Can this land since https://codereview.chromium.org/1235033008/ landed, or do we want to wait to make sure ...
5 years, 5 months ago (2015-07-15 15:20:05 UTC) #5
Nico
lgtm, ship it! (your link links to this CL; I guess you meant https://codereview.chromium.org/1234713002 :-) ...
5 years, 5 months ago (2015-07-15 16:08:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235033008/1
5 years, 5 months ago (2015-07-15 16:13:56 UTC) #8
Nico
woob woob http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/1719
5 years, 5 months ago (2015-07-16 22:44:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235033008/1
5 years, 5 months ago (2015-07-16 22:47:19 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 00:00:01 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 00:00:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5d0897658e728ea186c057ec414d53176913b2f
Cr-Commit-Position: refs/heads/master@{#339178}

Powered by Google App Engine
This is Rietveld 408576698