Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1234713002: win/clang: Roll clang 239674:242415 (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win/clang: Roll clang 239674:242415 32-bit SEH, member pointers with virtual bases, inttypes.h warning fix... BUG=509256, 82385 R=hans@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/2776ee378ee7d309d5d837e1e4405460403556ff Committed: https://chromium.googlesource.com/chromium/src/+/0d1b17f598c72f8672c5223439735ece5e6860f0

Patch Set 1 #

Patch Set 2 : 242006 #

Patch Set 3 : 242130 #

Patch Set 4 : 242415 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M build/common.gypi View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 1 chunk +3 lines, -11 lines 0 comments Download
M tools/clang/scripts/update.py View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Nico
5 years, 5 months ago (2015-07-13 18:03:08 UTC) #2
hans
lgtm
5 years, 5 months ago (2015-07-13 18:07:15 UTC) #3
Nico
Committed patchset #3 (id:40001) manually as 2776ee378ee7d309d5d837e1e4405460403556ff (presubmit successful).
5 years, 5 months ago (2015-07-15 15:03:18 UTC) #4
Nico
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1240813002/ by thakis@chromium.org. ...
5 years, 5 months ago (2015-07-15 19:36:44 UTC) #5
Nico
patch set 3 goes to 242415 (and unconditionally changes VERSION to 3.8.0)
5 years, 5 months ago (2015-07-16 19:38:47 UTC) #6
hans
On 2015/07/16 19:38:47, Nico wrote: > patch set 3 goes to 242415 (and unconditionally changes ...
5 years, 5 months ago (2015-07-16 19:41:13 UTC) #7
Nico
Committed patchset #4 (id:60001) manually as 0d1b17f598c72f8672c5223439735ece5e6860f0 (presubmit successful).
5 years, 5 months ago (2015-07-16 19:42:30 UTC) #8
Nico
On 2015/07/16 19:41:13, hans wrote: > On 2015/07/16 19:38:47, Nico wrote: > > patch set ...
5 years, 5 months ago (2015-07-16 19:45:54 UTC) #9
hans
5 years, 5 months ago (2015-07-16 19:50:45 UTC) #10
Message was sent while issue was closed.
On 2015/07/16 19:45:54, Nico wrote:
> On 2015/07/16 19:41:13, hans wrote:
> > On 2015/07/16 19:38:47, Nico wrote:
> > > patch set 3 goes to 242415 (and unconditionally changes VERSION to 3.8.0)
> > 
> > lgtm
> > 
> > Maybe mention Michael's size improvement too?
> 
> Well, they were what caused 242130 to be reverted and aren't in 242415 (242415
> is in fact the revision that reverted mkuper's change), so… :-)
> 
> (On the plus side, we'll see if this roll improves sizes too, and from the
diff
> between the improvement of the 239674:242130 roll and this roll we can figure
> out how much of the win is due to mkuper's patch)

Oh, I see.

Powered by Google App Engine
This is Rietveld 408576698