ui/android/java/res/drawable-v21/button_borderless_compat.xml - Issue 1235033003: Move ButtonCompat to ui/android/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/android/java/res/drawable-v21/button_borderless_compat.xml

Issue 1235033003: Move ButtonCompat to ui/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove buttonColor from chrome/android/. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/android/java/res/drawable-v21/button_borderless_compat.xml

diff --git a/chrome/android/java/res/drawable-v21/button_borderless_compat.xml b/ui/android/java/res/drawable-v21/button_borderless_compat.xml

similarity index 87%

rename from chrome/android/java/res/drawable-v21/button_borderless_compat.xml

rename to ui/android/java/res/drawable-v21/button_borderless_compat.xml

index 472fe1ce601b7e46b0ad25c77bcf50f1d2fa7a40..3401b43f5e49c5834b702178735aec213b1ec395 100644

--- a/chrome/android/java/res/drawable-v21/button_borderless_compat.xml

+++ b/ui/android/java/res/drawable-v21/button_borderless_compat.xml

@@ -4,7 +4,7 @@

found in the LICENSE file. -->

<ripple xmlns:android="http://schemas.android.com/apk/res/android"

- android:color="?attr/colorControlHighlight">

+ android:color="?attr/android:colorControlHighlight">

newt (away) 2015/07/14 01:39:59 This should be ?android:attr/colorControlHighl

please use gerrit instead 2015/07/14 21:16:39 Sorry, it's my first time :-) (No, it hasn't comp

<item android:id="@android:id/mask"

android:drawable="@drawable/button_compat_shape" />

</ripple>