ui/android/java/res/drawable-v21/button_borderless_compat.xml - Issue 1235033003: Move ButtonCompat to ui/android/

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/java/res/drawable-v21/button_borderless_compat.xml

Issue 1235033003: Move ButtonCompat to ui/android/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove buttonColor from chrome/android/. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <ripple xmlns:android="http://schemas.android.com/apk/res/android"	6 <ripple xmlns:android="http://schemas.android.com/apk/res/android"

7 android:color="?attr/colorControlHighlight">	7 android:color="?attr/android:colorControlHighlight">
	newt (away) 2015/07/14 01:39:59 This should be ?android:attr/colorControlHighl This should be ?android:attr/colorControlHighlight ... Does this even compile / where did you see this format recommended? please use gerrit instead 2015/07/14 21:16:39 Sorry, it's my first time :-) (No, it hasn't comp Show quoted text On 2015/07/14 01:39:59, newt wrote: > This should be > > ?android:attr/colorControlHighlight > > ... Does this even compile / where did you see this format recommended? Sorry, it's my first time :-) (No, it hasn't compiled yet because of lint warning treated as error.)
8 <item android:id="@android:id/mask"	8 <item android:id="@android:id/mask"

9 android:drawable="@drawable/button_compat_shape" />	9 android:drawable="@drawable/button_compat_shape" />

10 </ripple>	10 </ripple>

OLD	NEW