Move ButtonCompat to ui/android/

Move ButtonCompat to ui/android/

BUG=428087
Committed: https://crrev.com/4f26898a89194d2ebe928b220180ca6f24450de7
Cr-Commit-Position: refs/heads/master@{#338774}

[please use gerrit instead, 2015-07-14 01:22:41]

rouslan@chromium.org changed reviewers:
+ a@studioad.ru

[please use gerrit instead, 2015-07-14 01:22:42]

Aurimas, any idea why R.drawable.button_borderless_compat is flagged as unused
by lint? I suspect that styles.xml (which is using
R.drawable.button_borderless_compat) is not added to the build.

[please use gerrit instead, 2015-07-14 01:26:41]

rouslan@chromium.org changed reviewers:
- a@studioad.ru

[aurimas (slooooooooow), 2015-07-14 01:31:26]

aurimas@chromium.org changed reviewers:
+ aurimas@chromium.org, newt@chromium.org

[aurimas (slooooooooow), 2015-07-14 01:31:27]

+newt who is the owner of this

[newt (away), 2015-07-14 01:39:59]

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
File ui/android/java/res/drawable-v21/button_borderless_compat.xml (right):

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
ui/android/java/res/drawable-v21/button_borderless_compat.xml:7:
android:color="?attr/android:colorControlHighlight">
This should be

   ?android:attr/colorControlHighlight

... Does this even compile / where did you see this format recommended?

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
File ui/android/java/res/drawable-v21/button_compat.xml (right):

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
ui/android/java/res/drawable-v21/button_compat.xml:7:
android:color="?attr/android:colorControlHighlight">
Likewise, this should be

   ?android:attr/...

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/val...
File ui/android/java/res/values-v17/styles.xml (right):

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/val...
ui/android/java/res/values-v17/styles.xml:39: <item
name="android:background">?attr/android:selectableItemBackground</item>
android:attr

[newt (away), 2015-07-14 01:47:06]

Looks like you forgot to move styles from
chrome/android/java/res/values-v21/styles.xml to ui/

That would explain the unused resource exception

[please use gerrit instead, 2015-07-14 21:16:39]

On 2015/07/14 01:47:06, newt wrote:
> Looks like you forgot to move styles from
> chrome/android/java/res/values-v21/styles.xml to ui/
> 
> That would explain the unused resource exception

Thank you, that fixed the issue.

Newton, PTAL Patch Set 3.

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
File ui/android/java/res/drawable-v21/button_borderless_compat.xml (right):

https://codereview.chromium.org/1235033003/diff/20001/ui/android/java/res/dra...
ui/android/java/res/drawable-v21/button_borderless_compat.xml:7:
android:color="?attr/android:colorControlHighlight">
On 2015/07/14 01:39:59, newt wrote:
> This should be
> 
>    ?android:attr/colorControlHighlight
> 
> ... Does this even compile / where did you see this format recommended?

Sorry, it's my first time :-)

(No, it hasn't compiled yet because of lint warning treated as error.)

[newt (away), 2015-07-14 21:53:28]

lgtm

[please use gerrit instead, 2015-07-14 21:54:03]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2015-07-14 21:55:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235033003/40001

[commit-bot: I haz the power, 2015-07-14 22:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 22:10:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[please use gerrit instead, 2015-07-14 23:45:11]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2015-07-14 23:45:12]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1235033003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-07-14 23:45:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235033003/60001

[commit-bot: I haz the power, 2015-07-14 23:53:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-14 23:54:30]

Patchset 4 (id:??) landed as
https://crrev.com/4f26898a89194d2ebe928b220180ca6f24450de7
Cr-Commit-Position: refs/heads/master@{#338774}