Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/translate/core/common/translate_util.cc

Issue 1234973004: Update SplitString calls in components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/metrics/net/network_metrics_provider.cc ('K') | « components/translate/core/browser/translate_prefs.cc ('k') | components/translate/core/language_detection/language_detection_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/common/translate_util.cc
diff --git a/components/translate/core/common/translate_util.cc b/components/translate/core/common/translate_util.cc
index 35c54a9249b6073b30c30ac1a25bfd0e7a8ab1cb..7da2389f8a958f5a3c2afad173e816fda1173c2a 100644
--- a/components/translate/core/common/translate_util.cc
+++ b/components/translate/core/common/translate_util.cc
@@ -21,12 +21,12 @@ void SplitIntoMainAndTail(const std::string& language,
DCHECK(main_part);
DCHECK(tail_part);
- std::vector<std::string> chunks;
- base::SplitString(language, '-', &chunks);
- if (chunks.size() == 0u)
+ std::vector<base::StringPiece> chunks = base::SplitStringPiece(
+ language, "-", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
+ if (chunks.empty())
return;
- *main_part = chunks[0];
+ chunks[0].CopyToString(main_part);
*tail_part = language.substr(main_part->size());
}
« components/metrics/net/network_metrics_provider.cc ('K') | « components/translate/core/browser/translate_prefs.cc ('k') | components/translate/core/language_detection/language_detection_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698